POC protobuf communication over FFI #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoger
commented
Feb 6, 2019
thomcc
suggested changes
Feb 7, 2019
There was a problem hiding this comment.
Thanks a lot on this! This looks pretty cool.
I'd like doc comments on the ffi_support changes. Also, could you do a version bump on it when you're done?
I also think we should look into Prost, since the set_blah boilerplate is a bit of step backwards IMO. It seems pretty actively maintained, actually.
Also, the Int/Long distinction is a big issue too.
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/ProtoWrapper.kt
Outdated
Show resolved
Hide resolved
thomcc
reviewed
Feb 8, 2019
thomcc
reviewed
Feb 8, 2019
eoger
force-pushed
the
protobufs
branch
3 times, most recently
from
35fa958
to
041f0b7
Compare
|
Mind having a look again?
|
thomcc
approved these changes
Feb 12, 2019
vladikoff
approved these changes
Feb 12, 2019
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/ByteBuffer.kt
Show resolved
Hide resolved
components/fxa-client/android/src/main/java/org/mozilla/fxaclient/internal/Profile.kt
Show resolved
Hide resolved
eoger
force-pushed
the
protobufs
branch
2 times, most recently
from
2a669b3
to
e8a82eb
Compare
thomcc
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #612 for discussion.